mirrors/hono
mirrors/hono
0
0
Fork 0
mirror of https://github.com/honojs/hono.git synced 2024-12-01 11:51:01 +01:00
Code Issues Releases Activity

fix(client): continue if query value is undefined (#1368)

Browse Source 
* fix(client): `continue` if query value is `undefined`

* denoify
This commit is contained in:
Yusuke Wada 2023-08-23 09:11:25 +09:00 committed by GitHub
parent 2685a9b017
commit a168ed584b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 12 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
deno_dist/client/client.ts
View File

@ -42,7 +42,7 @@ class ClientRequestImpl {
if (args.query) { if (args.query) {
for (const [k, v] of Object.entries(args.query)) { for (const [k, v] of Object.entries(args.query)) {
if (v === undefined) { if (v === undefined) {
return continue
} }
this.queryParams ||= new URLSearchParams() this.queryParams ||= new URLSearchParams()

17
src/client/client.test.ts
View File

@ -128,15 +128,13 @@ describe('Basic - query, queries, form, and path params', () => {
.get( .get(
'/search', '/search',
validator('query', () => { validator('query', () => {
return {} as { q: string; tag: string[] } return {} as { q: string; tag: string[]; filter: string }
}), }),
(c) => { (c) => {
return c.jsonT({ return c.jsonT({
entries: [ q: 'fake',
{ tag: ['fake'],
title: 'Foo', filter: 'fake',
},
],
}) })
} }
) )
@ -170,11 +168,13 @@ describe('Basic - query, queries, form, and path params', () => {
const url = new URL(req.url) const url = new URL(req.url)
const query = url.searchParams.get('q') const query = url.searchParams.get('q')
const tag = url.searchParams.getAll('tag') const tag = url.searchParams.getAll('tag')
const filter = url.searchParams.get('filter')
return res( return res(
ctx.status(200), ctx.status(200),
ctx.json({ ctx.json({
q: query, q: query,
tag: tag, tag,
filter,
}) })
) )
}), }),
@ -209,6 +209,8 @@ describe('Basic - query, queries, form, and path params', () => {
query: { query: {
q: 'foobar', q: 'foobar',
tag: ['a', 'b'], tag: ['a', 'b'],
// @ts-expect-error
filter: undefined,
}, },
}) })
@ -216,6 +218,7 @@ describe('Basic - query, queries, form, and path params', () => {
expect(await res.json()).toEqual({ expect(await res.json()).toEqual({
q: 'foobar', q: 'foobar',
tag: ['a', 'b'], tag: ['a', 'b'],
filter: null,
}) })
}) })

2
src/client/client.ts
View File

@ -42,7 +42,7 @@ class ClientRequestImpl {
if (args.query) { if (args.query) {
for (const [k, v] of Object.entries(args.query)) { for (const [k, v] of Object.entries(args.query)) {
if (v === undefined) { if (v === undefined) {
return continue
} }
this.queryParams ||= new URLSearchParams() this.queryParams ||= new URLSearchParams()