From 4878fcf57cadaa89815c59d49341ea3353ee3db7 Mon Sep 17 00:00:00 2001 From: m-shaka Date: Mon, 23 Sep 2024 16:16:31 +0900 Subject: [PATCH] ci: prettify type check result and rm a comment (#3442) --- .github/workflows/ci.yml | 11 ++--------- perf-measures/type-check/scripts/process-results.ts | 2 +- 2 files changed, 3 insertions(+), 10 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index db9679c7..5dea3b9c 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -180,9 +180,6 @@ jobs: perf-measures-type-check-on-pr: runs-on: ubuntu-latest - permissions: - contents: 'read' - pull-requests: 'write' if: github.event_name == 'pull_request' steps: - uses: actions/checkout@v4 @@ -201,16 +198,12 @@ jobs: - run: | { echo 'COMPARISON<> "$GITHUB_ENV" working-directory: perf-measures/type-check - run: echo "$COMPARISON" - # remove the comment out after we make sure that caching is working - # - uses: thollander/actions-comment-pull-request@v2 - # with: - # comment_tag: perf-measures/type-check - # message: ${{ env.COMPARISON }} + name: display comparison perf-measures-type-check-on-main: diff --git a/perf-measures/type-check/scripts/process-results.ts b/perf-measures/type-check/scripts/process-results.ts index b1d10ec3..4e85e495 100644 --- a/perf-measures/type-check/scripts/process-results.ts +++ b/perf-measures/type-check/scripts/process-results.ts @@ -5,7 +5,7 @@ async function main() { const previousResult = await fs.readFile('./previous-result.txt') .then((data) => data.toString().split('\n')) .catch(() => null) - const table = ['|| Current | Previous |', '|---|---|---|'] + const table = ['| | Current | Previous |', '| --- | --- | --- |'] for (const [i, line] of currentResult.entries()) { if (line === '') {continue} const [name, value] = line.split(':')