0
0
mirror of https://github.com/go-gitea/gitea.git synced 2024-11-29 23:06:19 +01:00
gitea/web_src/js/features
wxiaoguang affdd40296
Make issue title edit buttons focusable and fix incorrect ajax requests (#22807)
Replace #19922 , which is stale since my last review:
https://github.com/go-gitea/gitea/pull/19922#pullrequestreview-1003546506
and https://github.com/go-gitea/gitea/pull/19922#issuecomment-1153181546

Close #19769

Changes:
1. Use `<button>` instead of `<div>` for buttons
2. Prevent default event handler in `initGlobalButtonClickOnEnter`
3. Fix the incorrect call to `pullrequest_targetbranch_change`
4. Add a slight margin-left to the input element to make UI look better

The logic in repo-issue.js is not ideal, but this PR isn't going to
touch the logic.

This is also an example for future developers to understand how to make
buttons work properly.

### Before


![image](https://user-images.githubusercontent.com/2114189/217262515-ec0462f7-7051-46a5-bfa2-2f6c6a807b7d.png)

### After

* Add a slight margin-left.
* The `Cancel` button is focused.


![image](https://user-images.githubusercontent.com/2114189/217264891-934c9c8d-d190-4866-98b5-666cea57e28d.png)

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
2023-02-09 12:11:16 -05:00
..
admin Improve AppUrl/ROOT_URL checking (#22836) 2023-02-09 11:14:45 -05:00
comp
aria.js Add ARIA support for Fomantic UI checkboxes (#22599) 2023-01-25 17:52:10 +02:00
aria.md
captcha.js Add new captcha: cloudflare turnstile (#22369) 2023-02-05 15:29:03 +08:00
citation.js
clipboard.js Use link in UI which returned a relative url but not html_url which contains an absolute url (#21986) 2023-02-06 12:09:18 -06:00
codeeditor.js
colorpicker.js
common-global.js Make issue title edit buttons focusable and fix incorrect ajax requests (#22807) 2023-02-09 12:11:16 -05:00
common-issue.js
common-organization.js
contextpopup.js
copycontent.js
dropzone.js
emoji.js
eventsource.sharedworker.js
file-fold.js
formatting.js
heatmap.js
imagediff.js Add missing close bracket in imagediff (#22710) 2023-02-01 19:48:35 +08:00
install.js
notification.js
org-team.js
pull-view-file.js
repo-branch.js
repo-code.js Fix links for the menus in the view file page (#22795) 2023-02-08 00:08:44 +08:00
repo-code.test.js
repo-commit.js
repo-common.js
repo-diff-filetree.js
repo-diff.js Restore function to "Show more" buttons (#22399) 2023-01-13 13:50:32 +08:00
repo-editor.js
repo-findfile.js Escape path for the file list (#22741) 2023-02-04 10:30:55 +00:00
repo-findfile.test.js Escape path for the file list (#22741) 2023-02-04 10:30:55 +00:00
repo-graph.js
repo-home.js
repo-issue-content.js
repo-issue-pr-form.js
repo-issue.js Make issue title edit buttons focusable and fix incorrect ajax requests (#22807) 2023-02-09 12:11:16 -05:00
repo-legacy.js
repo-migrate.js
repo-migration.js
repo-projects.js
repo-release.js Enable @<user>- completion popup on the release description textarea (#22359) 2023-02-01 13:14:40 -06:00
repo-settings.js
repo-template.js
repo-unicode-escape.js
repo-wiki.js
serviceworker.js
sshkey-helper.js
stopwatch.js Don't display stop watch top bar icon when disabled and hidden when click other place (#22374) 2023-01-09 21:53:11 -05:00
tablesort.js
tribute.js
user-auth-webauthn.js Fix bugs with WebAuthn preventing sign in and registration. (#22651) 2023-02-01 07:24:10 +00:00
user-auth.js
user-settings.js