mirror of
https://github.com/go-gitea/gitea.git
synced 2024-11-25 08:11:19 +01:00
027014d7de
Follow: * #22697 There are some bugs in #22697: * https://github.com/go-gitea/gitea/pull/22697#issuecomment-1577957966 * the webauthn failure message is never shown and causes console error * The `document.getElementById('register-button')` and `document.getElementById('login-button')` is wrong * there is no such element in code * it causes JS error when a browser doesn't provide webauthn * the end user can't see the real error message These bugs are fixed in this PR. Other changes: * Use simple HTML/CSS layouts, no need to use too many `gt-` patches * Make the webauthn page have correct "page-content" layout * The "data-webauthn-error-msg" elements are only used to provide locale texts, so move them into a single "gt-hidden", then no need to repeat a lot of "gt-hidden" in code * The `{{.CsrfTokenHtml}}` is a no-op because there is no form * Many `hideElem('#webauthn-error')` in code is no-op because the `webauthn-error` already has "gt-hidden" by default * Make the tests for "URLEncodedBase64" really test with concrete cases. Screenshots: * Error message when webauthn fails (before, there is no error message): <details> ![image](https://github.com/go-gitea/gitea/assets/2114189/93cf9559-d93b-4f06-9d98-0f7032d9c65b) </details> * Error message when webauthn is unavailable <details> ![image](https://github.com/go-gitea/gitea/assets/2114189/ffc0fcd9-b93b-4418-979c-c89bb627aaf2) </details> |
||
---|---|---|
.. | ||
admin | ||
comp | ||
captcha.js | ||
citation.js | ||
clipboard.js | ||
codeeditor.js | ||
colorpicker.js | ||
common-global.js | ||
common-issue-list.js | ||
common-issue-list.test.js | ||
common-organization.js | ||
contextpopup.js | ||
copycontent.js | ||
dropzone.js | ||
emoji.js | ||
eventsource.sharedworker.js | ||
file-fold.js | ||
heatmap.js | ||
imagediff.js | ||
install.js | ||
notification.js | ||
org-team.js | ||
pull-view-file.js | ||
repo-branch.js | ||
repo-code.js | ||
repo-code.test.js | ||
repo-commit.js | ||
repo-common.js | ||
repo-diff-filetree.js | ||
repo-diff.js | ||
repo-editor.js | ||
repo-findfile.js | ||
repo-findfile.test.js | ||
repo-graph.js | ||
repo-home.js | ||
repo-issue-content.js | ||
repo-issue-list.js | ||
repo-issue-pr-form.js | ||
repo-issue.js | ||
repo-legacy.js | ||
repo-migrate.js | ||
repo-migration.js | ||
repo-projects.js | ||
repo-release.js | ||
repo-settings.js | ||
repo-template.js | ||
repo-unicode-escape.js | ||
repo-wiki.js | ||
sshkey-helper.js | ||
stopwatch.js | ||
tablesort.js | ||
tribute.js | ||
user-auth-webauthn.js | ||
user-auth.js | ||
user-settings.js |