mirror of
https://github.com/django/django.git
synced 2024-11-29 22:56:46 +01:00
ded95ccdce
GenericIPAddressField must not allow blank for NOT NULL fields Thanks Erik Romijn.
167 lines
7.0 KiB
Python
167 lines
7.0 KiB
Python
from __future__ import absolute_import, unicode_literals
|
|
|
|
from django import forms
|
|
from django.core.exceptions import NON_FIELD_ERRORS
|
|
from django.test import TestCase
|
|
|
|
from . import ValidationTestCase
|
|
from .models import (Author, Article, ModelToValidate,
|
|
GenericIPAddressTestModel, GenericIPAddrUnpackUniqueTest)
|
|
|
|
|
|
class BaseModelValidationTests(ValidationTestCase):
|
|
|
|
def test_missing_required_field_raises_error(self):
|
|
mtv = ModelToValidate(f_with_custom_validator=42)
|
|
self.assertFailsValidation(mtv.full_clean, ['name', 'number'])
|
|
|
|
def test_with_correct_value_model_validates(self):
|
|
mtv = ModelToValidate(number=10, name='Some Name')
|
|
self.assertEqual(None, mtv.full_clean())
|
|
|
|
def test_custom_validate_method(self):
|
|
mtv = ModelToValidate(number=11)
|
|
self.assertFailsValidation(mtv.full_clean, [NON_FIELD_ERRORS, 'name'])
|
|
|
|
def test_wrong_FK_value_raises_error(self):
|
|
mtv=ModelToValidate(number=10, name='Some Name', parent_id=3)
|
|
self.assertFailsValidation(mtv.full_clean, ['parent'])
|
|
|
|
def test_correct_FK_value_validates(self):
|
|
parent = ModelToValidate.objects.create(number=10, name='Some Name')
|
|
mtv = ModelToValidate(number=10, name='Some Name', parent_id=parent.pk)
|
|
self.assertEqual(None, mtv.full_clean())
|
|
|
|
def test_limited_FK_raises_error(self):
|
|
# The limit_choices_to on the parent field says that a parent object's
|
|
# number attribute must be 10, so this should fail validation.
|
|
parent = ModelToValidate.objects.create(number=11, name='Other Name')
|
|
mtv = ModelToValidate(number=10, name='Some Name', parent_id=parent.pk)
|
|
self.assertFailsValidation(mtv.full_clean, ['parent'])
|
|
|
|
def test_wrong_email_value_raises_error(self):
|
|
mtv = ModelToValidate(number=10, name='Some Name', email='not-an-email')
|
|
self.assertFailsValidation(mtv.full_clean, ['email'])
|
|
|
|
def test_correct_email_value_passes(self):
|
|
mtv = ModelToValidate(number=10, name='Some Name', email='valid@email.com')
|
|
self.assertEqual(None, mtv.full_clean())
|
|
|
|
def test_wrong_url_value_raises_error(self):
|
|
mtv = ModelToValidate(number=10, name='Some Name', url='not a url')
|
|
self.assertFieldFailsValidationWithMessage(mtv.full_clean, 'url', ['Enter a valid URL.'])
|
|
|
|
def test_text_greater_that_charfields_max_length_raises_erros(self):
|
|
mtv = ModelToValidate(number=10, name='Some Name'*100)
|
|
self.assertFailsValidation(mtv.full_clean, ['name',])
|
|
|
|
|
|
class ArticleForm(forms.ModelForm):
|
|
class Meta:
|
|
model = Article
|
|
exclude = ['author']
|
|
|
|
class ModelFormsTests(TestCase):
|
|
def setUp(self):
|
|
self.author = Author.objects.create(name='Joseph Kocherhans')
|
|
|
|
def test_partial_validation(self):
|
|
# Make sure the "commit=False and set field values later" idiom still
|
|
# works with model validation.
|
|
data = {
|
|
'title': 'The state of model validation',
|
|
'pub_date': '2010-1-10 14:49:00'
|
|
}
|
|
form = ArticleForm(data)
|
|
self.assertEqual(list(form.errors), [])
|
|
article = form.save(commit=False)
|
|
article.author = self.author
|
|
article.save()
|
|
|
|
def test_validation_with_empty_blank_field(self):
|
|
# Since a value for pub_date wasn't provided and the field is
|
|
# blank=True, model-validation should pass.
|
|
# Also, Article.clean() should be run, so pub_date will be filled after
|
|
# validation, so the form should save cleanly even though pub_date is
|
|
# not allowed to be null.
|
|
data = {
|
|
'title': 'The state of model validation',
|
|
}
|
|
article = Article(author_id=self.author.id)
|
|
form = ArticleForm(data, instance=article)
|
|
self.assertEqual(list(form.errors), [])
|
|
self.assertNotEqual(form.instance.pub_date, None)
|
|
article = form.save()
|
|
|
|
def test_validation_with_invalid_blank_field(self):
|
|
# Even though pub_date is set to blank=True, an invalid value was
|
|
# provided, so it should fail validation.
|
|
data = {
|
|
'title': 'The state of model validation',
|
|
'pub_date': 'never'
|
|
}
|
|
article = Article(author_id=self.author.id)
|
|
form = ArticleForm(data, instance=article)
|
|
self.assertEqual(list(form.errors), ['pub_date'])
|
|
|
|
|
|
class GenericIPAddressFieldTests(ValidationTestCase):
|
|
|
|
def test_correct_generic_ip_passes(self):
|
|
giptm = GenericIPAddressTestModel(generic_ip="1.2.3.4")
|
|
self.assertIsNone(giptm.full_clean())
|
|
giptm = GenericIPAddressTestModel(generic_ip="2001::2")
|
|
self.assertIsNone(giptm.full_clean())
|
|
|
|
def test_invalid_generic_ip_raises_error(self):
|
|
giptm = GenericIPAddressTestModel(generic_ip="294.4.2.1")
|
|
self.assertFailsValidation(giptm.full_clean, ['generic_ip',])
|
|
giptm = GenericIPAddressTestModel(generic_ip="1:2")
|
|
self.assertFailsValidation(giptm.full_clean, ['generic_ip',])
|
|
|
|
def test_correct_v4_ip_passes(self):
|
|
giptm = GenericIPAddressTestModel(v4_ip="1.2.3.4")
|
|
self.assertIsNone(giptm.full_clean())
|
|
|
|
def test_invalid_v4_ip_raises_error(self):
|
|
giptm = GenericIPAddressTestModel(v4_ip="294.4.2.1")
|
|
self.assertFailsValidation(giptm.full_clean, ['v4_ip',])
|
|
giptm = GenericIPAddressTestModel(v4_ip="2001::2")
|
|
self.assertFailsValidation(giptm.full_clean, ['v4_ip',])
|
|
|
|
def test_correct_v6_ip_passes(self):
|
|
giptm = GenericIPAddressTestModel(v6_ip="2001::2")
|
|
self.assertIsNone(giptm.full_clean())
|
|
|
|
def test_invalid_v6_ip_raises_error(self):
|
|
giptm = GenericIPAddressTestModel(v6_ip="1.2.3.4")
|
|
self.assertFailsValidation(giptm.full_clean, ['v6_ip',])
|
|
giptm = GenericIPAddressTestModel(v6_ip="1:2")
|
|
self.assertFailsValidation(giptm.full_clean, ['v6_ip',])
|
|
|
|
def test_v6_uniqueness_detection(self):
|
|
# These two addresses are the same with different syntax
|
|
giptm = GenericIPAddressTestModel(generic_ip="2001::1:0:0:0:0:2")
|
|
giptm.save()
|
|
giptm = GenericIPAddressTestModel(generic_ip="2001:0:1:2")
|
|
self.assertFailsValidation(giptm.full_clean, ['generic_ip',])
|
|
|
|
def test_v4_unpack_uniqueness_detection(self):
|
|
# These two are different, because we are not doing IPv4 unpacking
|
|
giptm = GenericIPAddressTestModel(generic_ip="::ffff:10.10.10.10")
|
|
giptm.save()
|
|
giptm = GenericIPAddressTestModel(generic_ip="10.10.10.10")
|
|
self.assertIsNone(giptm.full_clean())
|
|
|
|
# These two are the same, because we are doing IPv4 unpacking
|
|
giptm = GenericIPAddrUnpackUniqueTest(generic_v4unpack_ip="::ffff:18.52.18.52")
|
|
giptm.save()
|
|
giptm = GenericIPAddrUnpackUniqueTest(generic_v4unpack_ip="18.52.18.52")
|
|
self.assertFailsValidation(giptm.full_clean, ['generic_v4unpack_ip',])
|
|
|
|
def test_empty_generic_ip_passes(self):
|
|
giptm = GenericIPAddressTestModel(generic_ip="")
|
|
self.assertIsNone(giptm.full_clean())
|
|
giptm = GenericIPAddressTestModel(generic_ip=None)
|
|
self.assertIsNone(giptm.full_clean())
|