mirror of
https://github.com/django/django.git
synced 2024-11-30 23:20:50 +01:00
c8b6594305
Subquery deconstruction support required implementing complex and
expensive equality rules for sql.Query objects for little benefit as
the latter cannot themselves be made deconstructible to their reference
to model classes.
Making Expression @deconstructible and not BaseExpression allows
interested parties to conform to the "expression" API even if they are
not deconstructible as it's only a requirement for expressions allowed
in Model fields and meta options (e.g. constraints, indexes).
Thanks Phillip Cutter for the report.
This also fixes a performance regression in bbf141bcdc.
144 lines
4.6 KiB
Python
144 lines
4.6 KiB
Python
from django.db.models import BooleanField, Exists, F, OuterRef, Q
|
|
from django.db.models.expressions import RawSQL
|
|
from django.test import SimpleTestCase
|
|
|
|
from .models import Tag
|
|
|
|
|
|
class QTests(SimpleTestCase):
|
|
def test_combine_and_empty(self):
|
|
q = Q(x=1)
|
|
self.assertEqual(q & Q(), q)
|
|
self.assertEqual(Q() & q, q)
|
|
|
|
q = Q(x__in={}.keys())
|
|
self.assertEqual(q & Q(), q)
|
|
self.assertEqual(Q() & q, q)
|
|
|
|
def test_combine_and_both_empty(self):
|
|
self.assertEqual(Q() & Q(), Q())
|
|
|
|
def test_combine_or_empty(self):
|
|
q = Q(x=1)
|
|
self.assertEqual(q | Q(), q)
|
|
self.assertEqual(Q() | q, q)
|
|
|
|
q = Q(x__in={}.keys())
|
|
self.assertEqual(q | Q(), q)
|
|
self.assertEqual(Q() | q, q)
|
|
|
|
def test_combine_empty_copy(self):
|
|
base_q = Q(x=1)
|
|
tests = [
|
|
base_q | Q(),
|
|
Q() | base_q,
|
|
base_q & Q(),
|
|
Q() & base_q,
|
|
]
|
|
for i, q in enumerate(tests):
|
|
with self.subTest(i=i):
|
|
self.assertEqual(q, base_q)
|
|
self.assertIsNot(q, base_q)
|
|
|
|
def test_combine_or_both_empty(self):
|
|
self.assertEqual(Q() | Q(), Q())
|
|
|
|
def test_combine_not_q_object(self):
|
|
obj = object()
|
|
q = Q(x=1)
|
|
with self.assertRaisesMessage(TypeError, str(obj)):
|
|
q | obj
|
|
with self.assertRaisesMessage(TypeError, str(obj)):
|
|
q & obj
|
|
|
|
def test_combine_negated_boolean_expression(self):
|
|
tagged = Tag.objects.filter(category=OuterRef('pk'))
|
|
tests = [
|
|
Q() & ~Exists(tagged),
|
|
Q() | ~Exists(tagged),
|
|
]
|
|
for q in tests:
|
|
with self.subTest(q=q):
|
|
self.assertIs(q.negated, True)
|
|
|
|
def test_deconstruct(self):
|
|
q = Q(price__gt=F('discounted_price'))
|
|
path, args, kwargs = q.deconstruct()
|
|
self.assertEqual(path, 'django.db.models.Q')
|
|
self.assertEqual(args, (('price__gt', F('discounted_price')),))
|
|
self.assertEqual(kwargs, {})
|
|
|
|
def test_deconstruct_negated(self):
|
|
q = ~Q(price__gt=F('discounted_price'))
|
|
path, args, kwargs = q.deconstruct()
|
|
self.assertEqual(args, (('price__gt', F('discounted_price')),))
|
|
self.assertEqual(kwargs, {'_negated': True})
|
|
|
|
def test_deconstruct_or(self):
|
|
q1 = Q(price__gt=F('discounted_price'))
|
|
q2 = Q(price=F('discounted_price'))
|
|
q = q1 | q2
|
|
path, args, kwargs = q.deconstruct()
|
|
self.assertEqual(args, (
|
|
('price__gt', F('discounted_price')),
|
|
('price', F('discounted_price')),
|
|
))
|
|
self.assertEqual(kwargs, {'_connector': 'OR'})
|
|
|
|
def test_deconstruct_and(self):
|
|
q1 = Q(price__gt=F('discounted_price'))
|
|
q2 = Q(price=F('discounted_price'))
|
|
q = q1 & q2
|
|
path, args, kwargs = q.deconstruct()
|
|
self.assertEqual(args, (
|
|
('price__gt', F('discounted_price')),
|
|
('price', F('discounted_price')),
|
|
))
|
|
self.assertEqual(kwargs, {})
|
|
|
|
def test_deconstruct_multiple_kwargs(self):
|
|
q = Q(price__gt=F('discounted_price'), price=F('discounted_price'))
|
|
path, args, kwargs = q.deconstruct()
|
|
self.assertEqual(args, (
|
|
('price', F('discounted_price')),
|
|
('price__gt', F('discounted_price')),
|
|
))
|
|
self.assertEqual(kwargs, {})
|
|
|
|
def test_deconstruct_nested(self):
|
|
q = Q(Q(price__gt=F('discounted_price')))
|
|
path, args, kwargs = q.deconstruct()
|
|
self.assertEqual(args, (Q(price__gt=F('discounted_price')),))
|
|
self.assertEqual(kwargs, {})
|
|
|
|
def test_deconstruct_boolean_expression(self):
|
|
expr = RawSQL('1 = 1', BooleanField())
|
|
q = Q(expr)
|
|
_, args, kwargs = q.deconstruct()
|
|
self.assertEqual(args, (expr,))
|
|
self.assertEqual(kwargs, {})
|
|
|
|
def test_reconstruct(self):
|
|
q = Q(price__gt=F('discounted_price'))
|
|
path, args, kwargs = q.deconstruct()
|
|
self.assertEqual(Q(*args, **kwargs), q)
|
|
|
|
def test_reconstruct_negated(self):
|
|
q = ~Q(price__gt=F('discounted_price'))
|
|
path, args, kwargs = q.deconstruct()
|
|
self.assertEqual(Q(*args, **kwargs), q)
|
|
|
|
def test_reconstruct_or(self):
|
|
q1 = Q(price__gt=F('discounted_price'))
|
|
q2 = Q(price=F('discounted_price'))
|
|
q = q1 | q2
|
|
path, args, kwargs = q.deconstruct()
|
|
self.assertEqual(Q(*args, **kwargs), q)
|
|
|
|
def test_reconstruct_and(self):
|
|
q1 = Q(price__gt=F('discounted_price'))
|
|
q2 = Q(price=F('discounted_price'))
|
|
q = q1 & q2
|
|
path, args, kwargs = q.deconstruct()
|
|
self.assertEqual(Q(*args, **kwargs), q)
|