0
0
mirror of https://github.com/django/django.git synced 2024-11-29 06:03:25 +01:00
Commit Graph

8 Commits

Author SHA1 Message Date
Nick Pope
962215db13 Organized images in the screenshots workflow.
Added a top-level directory in the zip archive that is the commit
hash which makes it easier when downloading multiple artifacts
for comparison. Updated the filenames of screenshots for easier
comparison between different cases. Added that an error is
raised if no screenshots uploaded in workflow.
2024-05-10 10:37:56 +02:00
Nick Pope
02c2090dc0 Optimized images in the screenshots workflow.
Running `oxipng` over a set of screenshots from a previous run that were
1.9M in size resulted in a total size of 1.3M, a 31.5% reduction.

This can be useful to reduce the artifact size stored in GitHub and
locally if downloading screenshots from multiple runs.

See https://til.simonwillison.net/github-actions/oxipng
2024-05-10 10:37:56 +02:00
Nick Pope
956f6610ec Removed obsolete logic from screenshots workflow.
The id was used when we attempted to update comments in an early
version of the feature. Also removed the job summary as it
doesn't have the value that it did in the original version of
the feature.
2024-05-10 10:37:56 +02:00
Mariusz Felisiak
e676f56527
Bumped versions in Github actions configuration. 2024-01-26 13:41:52 +01:00
Tom Carrick
0eaad0bb59
Removed unnecessary write permission from screenshots Github workflow. 2023-12-13 15:38:59 -03:00
Tom Carrick
ed65610653
Changed the screenshots Github workflow to run in the PR's branch by using pull_request as event trigger.
The original event trigger pull_request_target runs against the target branch (main), not the branch associated with the PR. Consequently, any new screenshots added in a PR are not captured, and the available screenshots reflect the state of the main branch code, not the code from the PR's branch.

This update addresses the issue by changing the event trigger to pull_request. However, it's important to note that this adjustment breaks the comments functionality since the action no longer has write permissions.
2023-12-12 13:22:32 -03:00
Mariusz Felisiak
86ae1a3b6c
Fixed permissions for GitHub action with screenshots.
Follow up to 97b7970c64.
2023-10-19 13:37:05 +02:00
Sarah Boyce
97b7970c64 Refs #34043 -- Added GitHub action to capture screenshots in Selenium tests. 2023-10-18 11:19:54 +02:00