mirror of
https://github.com/django/django.git
synced 2024-12-01 15:42:04 +01:00
Fixed #30516 -- Fixed crash of autoreloader when re-raising exceptions with custom signature.
Regression in c8720e7696
.
This commit is contained in:
parent
fcbc502af9
commit
0344565179
@ -74,7 +74,7 @@ def check_errors(fn):
|
||||
def raise_last_exception():
|
||||
global _exception
|
||||
if _exception is not None:
|
||||
raise _exception[0](_exception[1]).with_traceback(_exception[2])
|
||||
raise _exception[1]
|
||||
|
||||
|
||||
def ensure_echo_on():
|
||||
|
@ -25,3 +25,6 @@ Bugfixes
|
||||
* Fixed crash of :class:`~django.contrib.postgres.aggregates.ArrayAgg` and
|
||||
:class:`~django.contrib.postgres.aggregates.StringAgg` with ``ordering``
|
||||
argument when used in a ``Subquery`` (:ticket:`30315`).
|
||||
|
||||
* Fixed a regression in Django 2.2 that caused a crash of auto-reloader when
|
||||
an exception with custom signature is raised (:ticket:`30516`).
|
||||
|
@ -295,6 +295,36 @@ class TestRaiseLastException(SimpleTestCase):
|
||||
with self.assertRaisesMessage(MyException, 'Test Message'):
|
||||
autoreload.raise_last_exception()
|
||||
|
||||
def test_raises_custom_exception(self):
|
||||
class MyException(Exception):
|
||||
def __init__(self, msg, extra_context):
|
||||
super().__init__(msg)
|
||||
self.extra_context = extra_context
|
||||
# Create an exception.
|
||||
try:
|
||||
raise MyException('Test Message', 'extra context')
|
||||
except MyException:
|
||||
exc_info = sys.exc_info()
|
||||
|
||||
with mock.patch('django.utils.autoreload._exception', exc_info):
|
||||
with self.assertRaisesMessage(MyException, 'Test Message'):
|
||||
autoreload.raise_last_exception()
|
||||
|
||||
def test_raises_exception_with_context(self):
|
||||
try:
|
||||
raise Exception(2)
|
||||
except Exception as e:
|
||||
try:
|
||||
raise Exception(1) from e
|
||||
except Exception:
|
||||
exc_info = sys.exc_info()
|
||||
|
||||
with mock.patch('django.utils.autoreload._exception', exc_info):
|
||||
with self.assertRaises(Exception) as cm:
|
||||
autoreload.raise_last_exception()
|
||||
self.assertEqual(cm.exception.args[0], 1)
|
||||
self.assertEqual(cm.exception.__cause__.args[0], 2)
|
||||
|
||||
|
||||
class RestartWithReloaderTests(SimpleTestCase):
|
||||
executable = '/usr/bin/python'
|
||||
|
Loading…
Reference in New Issue
Block a user