Fixed #20869 -- made CSRF tokens change every request by salt-encrypting them
Note that the cookie is not changed every request, just the token retrieved
by the `get_token()` method (used also by the `{% csrf_token %}` tag).
While at it, made token validation strict: Where, before, any length was
accepted and non-ASCII chars were ignored, we now treat anything other than
`[A-Za-z0-9]{64}` as invalid (except for 32-char tokens, which, for
backwards-compatibility, are accepted and replaced by 64-char ones).
Thanks Trac user patrys for reporting, github user adambrenecki
for initial patch, Tim Graham for help, and Curtis Maloney,
Collin Anderson, Florian Apolloner, Markus Holtermann & Jon Dufresne
for reviews.
2015-11-07 17:35:45 +01:00
|
|
|
import re
|
|
|
|
|
2015-03-10 21:21:28 +01:00
|
|
|
from django.forms import CharField, Form, Media
|
2014-12-14 21:22:57 +01:00
|
|
|
from django.http import HttpRequest
|
Fixed #20869 -- made CSRF tokens change every request by salt-encrypting them
Note that the cookie is not changed every request, just the token retrieved
by the `get_token()` method (used also by the `{% csrf_token %}` tag).
While at it, made token validation strict: Where, before, any length was
accepted and non-ASCII chars were ignored, we now treat anything other than
`[A-Za-z0-9]{64}` as invalid (except for 32-char tokens, which, for
backwards-compatibility, are accepted and replaced by 64-char ones).
Thanks Trac user patrys for reporting, github user adambrenecki
for initial patch, Tim Graham for help, and Curtis Maloney,
Collin Anderson, Florian Apolloner, Markus Holtermann & Jon Dufresne
for reviews.
2015-11-07 17:35:45 +01:00
|
|
|
from django.middleware.csrf import (
|
|
|
|
CsrfViewMiddleware, _compare_salted_tokens as equivalent_tokens, get_token,
|
|
|
|
)
|
2015-01-10 21:35:09 +01:00
|
|
|
from django.template import TemplateDoesNotExist, TemplateSyntaxError
|
2014-12-14 21:22:57 +01:00
|
|
|
from django.template.backends.dummy import TemplateStrings
|
|
|
|
from django.test import SimpleTestCase
|
|
|
|
|
|
|
|
|
|
|
|
class TemplateStringsTests(SimpleTestCase):
|
|
|
|
|
|
|
|
engine_class = TemplateStrings
|
|
|
|
backend_name = 'dummy'
|
|
|
|
options = {}
|
|
|
|
|
|
|
|
@classmethod
|
|
|
|
def setUpClass(cls):
|
2015-04-16 22:37:58 +02:00
|
|
|
super(TemplateStringsTests, cls).setUpClass()
|
2014-12-14 21:22:57 +01:00
|
|
|
params = {
|
|
|
|
'DIRS': [],
|
|
|
|
'APP_DIRS': True,
|
|
|
|
'NAME': cls.backend_name,
|
|
|
|
'OPTIONS': cls.options,
|
|
|
|
}
|
|
|
|
cls.engine = cls.engine_class(params)
|
|
|
|
|
|
|
|
def test_from_string(self):
|
|
|
|
template = self.engine.from_string("Hello!\n")
|
|
|
|
content = template.render()
|
|
|
|
self.assertEqual(content, "Hello!\n")
|
|
|
|
|
|
|
|
def test_get_template(self):
|
|
|
|
template = self.engine.get_template('template_backends/hello.html')
|
|
|
|
content = template.render({'name': 'world'})
|
|
|
|
self.assertEqual(content, "Hello world!\n")
|
|
|
|
|
|
|
|
def test_get_template_non_existing(self):
|
2015-04-24 21:33:03 +02:00
|
|
|
with self.assertRaises(TemplateDoesNotExist) as e:
|
2014-12-14 21:22:57 +01:00
|
|
|
self.engine.get_template('template_backends/non_existing.html')
|
2015-04-24 21:33:03 +02:00
|
|
|
self.assertEqual(e.exception.backend, self.engine)
|
2014-12-14 21:22:57 +01:00
|
|
|
|
2015-01-10 21:35:09 +01:00
|
|
|
def test_get_template_syntax_error(self):
|
|
|
|
# There's no way to trigger a syntax error with the dummy backend.
|
|
|
|
# The test still lives here to factor it between other backends.
|
|
|
|
if self.backend_name == 'dummy':
|
2015-03-10 21:21:28 +01:00
|
|
|
self.skipTest("test doesn't apply to dummy backend")
|
2015-01-10 21:35:09 +01:00
|
|
|
with self.assertRaises(TemplateSyntaxError):
|
|
|
|
self.engine.get_template('template_backends/syntax_error.html')
|
|
|
|
|
2014-12-14 21:22:57 +01:00
|
|
|
def test_html_escaping(self):
|
|
|
|
template = self.engine.get_template('template_backends/hello.html')
|
|
|
|
context = {'name': '<script>alert("XSS!");</script>'}
|
|
|
|
content = template.render(context)
|
|
|
|
|
|
|
|
self.assertIn('<script>', content)
|
|
|
|
self.assertNotIn('<script>', content)
|
|
|
|
|
2015-03-10 21:21:28 +01:00
|
|
|
def test_django_html_escaping(self):
|
|
|
|
if self.backend_name == 'dummy':
|
|
|
|
self.skipTest("test doesn't apply to dummy backend")
|
|
|
|
|
|
|
|
class TestForm(Form):
|
|
|
|
test_field = CharField()
|
|
|
|
|
|
|
|
media = Media(js=['my-script.js'])
|
|
|
|
form = TestForm()
|
|
|
|
template = self.engine.get_template('template_backends/django_escaping.html')
|
|
|
|
content = template.render({'media': media, 'test_form': form})
|
|
|
|
|
|
|
|
expected = '{}\n\n{}\n\n{}'.format(media, form, form['test_field'])
|
|
|
|
|
|
|
|
self.assertHTMLEqual(content, expected)
|
|
|
|
|
2014-12-14 21:22:57 +01:00
|
|
|
def test_csrf_token(self):
|
|
|
|
request = HttpRequest()
|
|
|
|
CsrfViewMiddleware().process_view(request, lambda r: None, (), {})
|
|
|
|
|
|
|
|
template = self.engine.get_template('template_backends/csrf.html')
|
|
|
|
content = template.render(request=request)
|
|
|
|
|
Fixed #20869 -- made CSRF tokens change every request by salt-encrypting them
Note that the cookie is not changed every request, just the token retrieved
by the `get_token()` method (used also by the `{% csrf_token %}` tag).
While at it, made token validation strict: Where, before, any length was
accepted and non-ASCII chars were ignored, we now treat anything other than
`[A-Za-z0-9]{64}` as invalid (except for 32-char tokens, which, for
backwards-compatibility, are accepted and replaced by 64-char ones).
Thanks Trac user patrys for reporting, github user adambrenecki
for initial patch, Tim Graham for help, and Curtis Maloney,
Collin Anderson, Florian Apolloner, Markus Holtermann & Jon Dufresne
for reviews.
2015-11-07 17:35:45 +01:00
|
|
|
expected = '<input type="hidden" name="csrfmiddlewaretoken" value="([^"]+)" />'
|
|
|
|
match = re.match(expected, content) or re.match(expected.replace('"', "'"), content)
|
|
|
|
self.assertTrue(match, "hidden csrftoken field not found in output")
|
|
|
|
self.assertTrue(equivalent_tokens(match.group(1), get_token(request)))
|
2014-12-14 21:22:57 +01:00
|
|
|
|
|
|
|
def test_no_directory_traversal(self):
|
|
|
|
with self.assertRaises(TemplateDoesNotExist):
|
|
|
|
self.engine.get_template('../forbidden/template_backends/hello.html')
|
|
|
|
|
|
|
|
def test_non_ascii_characters(self):
|
|
|
|
template = self.engine.get_template('template_backends/hello.html')
|
|
|
|
content = template.render({'name': 'Jérôme'})
|
|
|
|
self.assertEqual(content, "Hello Jérôme!\n")
|