mirror of
https://github.com/python/cpython.git
synced 2024-11-25 09:39:56 +01:00
362cd2680b
Fix a race in `PyMember_GetOne` and `PyMember_SetOne` for `Py_T_OBJECT_EX`. These functions implement `__slots__` accesses for Python objects.
366 lines
11 KiB
C
366 lines
11 KiB
C
|
|
/* Map C struct members to Python object attributes */
|
|
|
|
#include "Python.h"
|
|
#include "pycore_abstract.h" // _PyNumber_Index()
|
|
#include "pycore_long.h" // _PyLong_IsNegative()
|
|
#include "pycore_object.h" // _Py_TryIncrefCompare(), FT_ATOMIC_*()
|
|
#include "pycore_critical_section.h"
|
|
|
|
|
|
static inline PyObject *
|
|
member_get_object(const char *addr, const char *obj_addr, PyMemberDef *l)
|
|
{
|
|
PyObject *v = FT_ATOMIC_LOAD_PTR(*(PyObject **) addr);
|
|
if (v == NULL) {
|
|
PyErr_Format(PyExc_AttributeError,
|
|
"'%T' object has no attribute '%s'",
|
|
(PyObject *)obj_addr, l->name);
|
|
}
|
|
return v;
|
|
}
|
|
|
|
PyObject *
|
|
PyMember_GetOne(const char *obj_addr, PyMemberDef *l)
|
|
{
|
|
PyObject *v;
|
|
if (l->flags & Py_RELATIVE_OFFSET) {
|
|
PyErr_SetString(
|
|
PyExc_SystemError,
|
|
"PyMember_GetOne used with Py_RELATIVE_OFFSET");
|
|
return NULL;
|
|
}
|
|
|
|
const char* addr = obj_addr + l->offset;
|
|
switch (l->type) {
|
|
case Py_T_BOOL:
|
|
v = PyBool_FromLong(*(char*)addr);
|
|
break;
|
|
case Py_T_BYTE:
|
|
v = PyLong_FromLong(*(char*)addr);
|
|
break;
|
|
case Py_T_UBYTE:
|
|
v = PyLong_FromUnsignedLong(*(unsigned char*)addr);
|
|
break;
|
|
case Py_T_SHORT:
|
|
v = PyLong_FromLong(*(short*)addr);
|
|
break;
|
|
case Py_T_USHORT:
|
|
v = PyLong_FromUnsignedLong(*(unsigned short*)addr);
|
|
break;
|
|
case Py_T_INT:
|
|
v = PyLong_FromLong(*(int*)addr);
|
|
break;
|
|
case Py_T_UINT:
|
|
v = PyLong_FromUnsignedLong(*(unsigned int*)addr);
|
|
break;
|
|
case Py_T_LONG:
|
|
v = PyLong_FromLong(*(long*)addr);
|
|
break;
|
|
case Py_T_ULONG:
|
|
v = PyLong_FromUnsignedLong(*(unsigned long*)addr);
|
|
break;
|
|
case Py_T_PYSSIZET:
|
|
v = PyLong_FromSsize_t(*(Py_ssize_t*)addr);
|
|
break;
|
|
case Py_T_FLOAT:
|
|
v = PyFloat_FromDouble((double)*(float*)addr);
|
|
break;
|
|
case Py_T_DOUBLE:
|
|
v = PyFloat_FromDouble(*(double*)addr);
|
|
break;
|
|
case Py_T_STRING:
|
|
if (*(char**)addr == NULL) {
|
|
v = Py_NewRef(Py_None);
|
|
}
|
|
else
|
|
v = PyUnicode_FromString(*(char**)addr);
|
|
break;
|
|
case Py_T_STRING_INPLACE:
|
|
v = PyUnicode_FromString((char*)addr);
|
|
break;
|
|
case Py_T_CHAR:
|
|
v = PyUnicode_FromStringAndSize((char*)addr, 1);
|
|
break;
|
|
case _Py_T_OBJECT:
|
|
v = *(PyObject **)addr;
|
|
if (v == NULL)
|
|
v = Py_None;
|
|
Py_INCREF(v);
|
|
break;
|
|
case Py_T_OBJECT_EX:
|
|
v = member_get_object(addr, obj_addr, l);
|
|
#ifndef Py_GIL_DISABLED
|
|
Py_XINCREF(v);
|
|
#else
|
|
if (v != NULL) {
|
|
if (!_Py_TryIncrefCompare((PyObject **) addr, v)) {
|
|
Py_BEGIN_CRITICAL_SECTION((PyObject *) obj_addr);
|
|
v = member_get_object(addr, obj_addr, l);
|
|
Py_XINCREF(v);
|
|
Py_END_CRITICAL_SECTION();
|
|
}
|
|
}
|
|
#endif
|
|
break;
|
|
case Py_T_LONGLONG:
|
|
v = PyLong_FromLongLong(*(long long *)addr);
|
|
break;
|
|
case Py_T_ULONGLONG:
|
|
v = PyLong_FromUnsignedLongLong(*(unsigned long long *)addr);
|
|
break;
|
|
case _Py_T_NONE:
|
|
// doesn't require free-threading code path
|
|
v = Py_NewRef(Py_None);
|
|
break;
|
|
default:
|
|
PyErr_SetString(PyExc_SystemError, "bad memberdescr type");
|
|
v = NULL;
|
|
}
|
|
return v;
|
|
}
|
|
|
|
#define WARN(msg) \
|
|
do { \
|
|
if (PyErr_WarnEx(PyExc_RuntimeWarning, msg, 1) < 0) \
|
|
return -1; \
|
|
} while (0)
|
|
|
|
int
|
|
PyMember_SetOne(char *addr, PyMemberDef *l, PyObject *v)
|
|
{
|
|
PyObject *oldv;
|
|
if (l->flags & Py_RELATIVE_OFFSET) {
|
|
PyErr_SetString(
|
|
PyExc_SystemError,
|
|
"PyMember_SetOne used with Py_RELATIVE_OFFSET");
|
|
return -1;
|
|
}
|
|
|
|
#ifdef Py_GIL_DISABLED
|
|
PyObject *obj = (PyObject *) addr;
|
|
#endif
|
|
addr += l->offset;
|
|
|
|
if ((l->flags & Py_READONLY))
|
|
{
|
|
PyErr_SetString(PyExc_AttributeError, "readonly attribute");
|
|
return -1;
|
|
}
|
|
if (v == NULL) {
|
|
if (l->type == Py_T_OBJECT_EX) {
|
|
/* Check if the attribute is set. */
|
|
if (*(PyObject **)addr == NULL) {
|
|
PyErr_SetString(PyExc_AttributeError, l->name);
|
|
return -1;
|
|
}
|
|
}
|
|
else if (l->type != _Py_T_OBJECT) {
|
|
PyErr_SetString(PyExc_TypeError,
|
|
"can't delete numeric/char attribute");
|
|
return -1;
|
|
}
|
|
}
|
|
switch (l->type) {
|
|
case Py_T_BOOL:{
|
|
if (!PyBool_Check(v)) {
|
|
PyErr_SetString(PyExc_TypeError,
|
|
"attribute value type must be bool");
|
|
return -1;
|
|
}
|
|
if (v == Py_True)
|
|
*(char*)addr = (char) 1;
|
|
else
|
|
*(char*)addr = (char) 0;
|
|
break;
|
|
}
|
|
case Py_T_BYTE:{
|
|
long long_val = PyLong_AsLong(v);
|
|
if ((long_val == -1) && PyErr_Occurred())
|
|
return -1;
|
|
*(char*)addr = (char)long_val;
|
|
/* XXX: For compatibility, only warn about truncations
|
|
for now. */
|
|
if ((long_val > CHAR_MAX) || (long_val < CHAR_MIN))
|
|
WARN("Truncation of value to char");
|
|
break;
|
|
}
|
|
case Py_T_UBYTE:{
|
|
long long_val = PyLong_AsLong(v);
|
|
if ((long_val == -1) && PyErr_Occurred())
|
|
return -1;
|
|
*(unsigned char*)addr = (unsigned char)long_val;
|
|
if ((long_val > UCHAR_MAX) || (long_val < 0))
|
|
WARN("Truncation of value to unsigned char");
|
|
break;
|
|
}
|
|
case Py_T_SHORT:{
|
|
long long_val = PyLong_AsLong(v);
|
|
if ((long_val == -1) && PyErr_Occurred())
|
|
return -1;
|
|
*(short*)addr = (short)long_val;
|
|
if ((long_val > SHRT_MAX) || (long_val < SHRT_MIN))
|
|
WARN("Truncation of value to short");
|
|
break;
|
|
}
|
|
case Py_T_USHORT:{
|
|
long long_val = PyLong_AsLong(v);
|
|
if ((long_val == -1) && PyErr_Occurred())
|
|
return -1;
|
|
*(unsigned short*)addr = (unsigned short)long_val;
|
|
if ((long_val > USHRT_MAX) || (long_val < 0))
|
|
WARN("Truncation of value to unsigned short");
|
|
break;
|
|
}
|
|
case Py_T_INT:{
|
|
long long_val = PyLong_AsLong(v);
|
|
if ((long_val == -1) && PyErr_Occurred())
|
|
return -1;
|
|
*(int *)addr = (int)long_val;
|
|
if ((long_val > INT_MAX) || (long_val < INT_MIN))
|
|
WARN("Truncation of value to int");
|
|
break;
|
|
}
|
|
case Py_T_UINT: {
|
|
/* XXX: For compatibility, accept negative int values
|
|
as well. */
|
|
v = _PyNumber_Index(v);
|
|
if (v == NULL) {
|
|
return -1;
|
|
}
|
|
if (_PyLong_IsNegative((PyLongObject *)v)) {
|
|
long long_val = PyLong_AsLong(v);
|
|
Py_DECREF(v);
|
|
if (long_val == -1 && PyErr_Occurred()) {
|
|
return -1;
|
|
}
|
|
*(unsigned int *)addr = (unsigned int)(unsigned long)long_val;
|
|
WARN("Writing negative value into unsigned field");
|
|
}
|
|
else {
|
|
unsigned long ulong_val = PyLong_AsUnsignedLong(v);
|
|
Py_DECREF(v);
|
|
if (ulong_val == (unsigned long)-1 && PyErr_Occurred()) {
|
|
return -1;
|
|
}
|
|
*(unsigned int*)addr = (unsigned int)ulong_val;
|
|
if (ulong_val > UINT_MAX) {
|
|
WARN("Truncation of value to unsigned int");
|
|
}
|
|
}
|
|
break;
|
|
}
|
|
case Py_T_LONG:{
|
|
*(long*)addr = PyLong_AsLong(v);
|
|
if ((*(long*)addr == -1) && PyErr_Occurred())
|
|
return -1;
|
|
break;
|
|
}
|
|
case Py_T_ULONG: {
|
|
/* XXX: For compatibility, accept negative int values
|
|
as well. */
|
|
v = _PyNumber_Index(v);
|
|
if (v == NULL) {
|
|
return -1;
|
|
}
|
|
if (_PyLong_IsNegative((PyLongObject *)v)) {
|
|
long long_val = PyLong_AsLong(v);
|
|
Py_DECREF(v);
|
|
if (long_val == -1 && PyErr_Occurred()) {
|
|
return -1;
|
|
}
|
|
*(unsigned long *)addr = (unsigned long)long_val;
|
|
WARN("Writing negative value into unsigned field");
|
|
}
|
|
else {
|
|
unsigned long ulong_val = PyLong_AsUnsignedLong(v);
|
|
Py_DECREF(v);
|
|
if (ulong_val == (unsigned long)-1 && PyErr_Occurred()) {
|
|
return -1;
|
|
}
|
|
*(unsigned long*)addr = ulong_val;
|
|
}
|
|
break;
|
|
}
|
|
case Py_T_PYSSIZET:{
|
|
*(Py_ssize_t*)addr = PyLong_AsSsize_t(v);
|
|
if ((*(Py_ssize_t*)addr == (Py_ssize_t)-1)
|
|
&& PyErr_Occurred())
|
|
return -1;
|
|
break;
|
|
}
|
|
case Py_T_FLOAT:{
|
|
double double_val = PyFloat_AsDouble(v);
|
|
if ((double_val == -1) && PyErr_Occurred())
|
|
return -1;
|
|
*(float*)addr = (float)double_val;
|
|
break;
|
|
}
|
|
case Py_T_DOUBLE:
|
|
*(double*)addr = PyFloat_AsDouble(v);
|
|
if ((*(double*)addr == -1) && PyErr_Occurred())
|
|
return -1;
|
|
break;
|
|
case _Py_T_OBJECT:
|
|
case Py_T_OBJECT_EX:
|
|
Py_BEGIN_CRITICAL_SECTION(obj);
|
|
oldv = *(PyObject **)addr;
|
|
FT_ATOMIC_STORE_PTR_RELEASE(*(PyObject **)addr, Py_XNewRef(v));
|
|
Py_END_CRITICAL_SECTION();
|
|
Py_XDECREF(oldv);
|
|
break;
|
|
case Py_T_CHAR: {
|
|
const char *string;
|
|
Py_ssize_t len;
|
|
|
|
string = PyUnicode_AsUTF8AndSize(v, &len);
|
|
if (string == NULL || len != 1) {
|
|
PyErr_BadArgument();
|
|
return -1;
|
|
}
|
|
*(char*)addr = string[0];
|
|
break;
|
|
}
|
|
case Py_T_STRING:
|
|
case Py_T_STRING_INPLACE:
|
|
PyErr_SetString(PyExc_TypeError, "readonly attribute");
|
|
return -1;
|
|
case Py_T_LONGLONG:{
|
|
long long value;
|
|
*(long long*)addr = value = PyLong_AsLongLong(v);
|
|
if ((value == -1) && PyErr_Occurred())
|
|
return -1;
|
|
break;
|
|
}
|
|
case Py_T_ULONGLONG: {
|
|
v = _PyNumber_Index(v);
|
|
if (v == NULL) {
|
|
return -1;
|
|
}
|
|
if (_PyLong_IsNegative((PyLongObject *)v)) {
|
|
long long_val = PyLong_AsLong(v);
|
|
Py_DECREF(v);
|
|
if (long_val == -1 && PyErr_Occurred()) {
|
|
return -1;
|
|
}
|
|
*(unsigned long long *)addr = (unsigned long long)(long long)long_val;
|
|
WARN("Writing negative value into unsigned field");
|
|
}
|
|
else {
|
|
unsigned long long ulonglong_val = PyLong_AsUnsignedLongLong(v);
|
|
Py_DECREF(v);
|
|
if (ulonglong_val == (unsigned long long)-1 && PyErr_Occurred()) {
|
|
return -1;
|
|
}
|
|
*(unsigned long long*)addr = ulonglong_val;
|
|
}
|
|
break;
|
|
}
|
|
default:
|
|
PyErr_Format(PyExc_SystemError,
|
|
"bad memberdescr type for %s", l->name);
|
|
return -1;
|
|
}
|
|
return 0;
|
|
}
|