mirror of
https://github.com/python/cpython.git
synced 2024-11-25 09:39:56 +01:00
6b179adb8c
There is a WIP proposal to enable webassembly stack switching which have been implemented in v8: https://github.com/WebAssembly/js-promise-integration It is not possible to switch stacks that contain JS frames so the Emscripten JS trampolines that allow calling functions with the wrong number of arguments don't work in this case. However, the js-promise-integration proposal requires the [type reflection for Wasm/JS API](https://github.com/WebAssembly/js-types) proposal, which allows us to actually count the number of arguments a function expects. For better compatibility with stack switching, this PR checks if type reflection is available, and if so we use a switch block to decide the appropriate signature. If type reflection is unavailable, we should use the current EMJS trampoline. We cache the function argument counts since when I didn't cache them performance was negatively affected. Co-authored-by: T. Wouters <thomas@python.org> Co-authored-by: Brett Cannon <brett@python.org>
82 lines
3.1 KiB
C
82 lines
3.1 KiB
C
#ifndef Py_EMSCRIPTEN_TRAMPOLINE_H
|
|
#define Py_EMSCRIPTEN_TRAMPOLINE_H
|
|
|
|
#include "pycore_runtime.h" // _PyRuntimeState
|
|
|
|
/**
|
|
* C function call trampolines to mitigate bad function pointer casts.
|
|
*
|
|
* Section 6.3.2.3, paragraph 8 reads:
|
|
*
|
|
* A pointer to a function of one type may be converted to a pointer to a
|
|
* function of another type and back again; the result shall compare equal to
|
|
* the original pointer. If a converted pointer is used to call a function
|
|
* whose type is not compatible with the pointed-to type, the behavior is
|
|
* undefined.
|
|
*
|
|
* Typical native ABIs ignore additional arguments or fill in missing values
|
|
* with 0/NULL in function pointer cast. Compilers do not show warnings when a
|
|
* function pointer is explicitly casted to an incompatible type.
|
|
*
|
|
* Bad fpcasts are an issue in WebAssembly. WASM's indirect_call has strict
|
|
* function signature checks. Argument count, types, and return type must match.
|
|
*
|
|
* Third party code unintentionally rely on problematic fpcasts. The call
|
|
* trampoline mitigates common occurrences of bad fpcasts on Emscripten.
|
|
*/
|
|
|
|
#if defined(__EMSCRIPTEN__) && defined(PY_CALL_TRAMPOLINE)
|
|
|
|
void _Py_EmscriptenTrampoline_Init(_PyRuntimeState *runtime);
|
|
|
|
PyObject*
|
|
_PyEM_TrampolineCall_JavaScript(PyCFunctionWithKeywords func,
|
|
PyObject* self,
|
|
PyObject* args,
|
|
PyObject* kw);
|
|
|
|
PyObject*
|
|
_PyEM_TrampolineCall_Reflection(PyCFunctionWithKeywords func,
|
|
PyObject* self,
|
|
PyObject* args,
|
|
PyObject* kw);
|
|
|
|
#define _PyEM_TrampolineCall(meth, self, args, kw) \
|
|
((_PyRuntime.wasm_type_reflection_available) ? \
|
|
(_PyEM_TrampolineCall_Reflection((PyCFunctionWithKeywords)(meth), (self), (args), (kw))) : \
|
|
(_PyEM_TrampolineCall_JavaScript((PyCFunctionWithKeywords)(meth), (self), (args), (kw))))
|
|
|
|
#define _PyCFunction_TrampolineCall(meth, self, args) \
|
|
_PyEM_TrampolineCall( \
|
|
(*(PyCFunctionWithKeywords)(void(*)(void))(meth)), (self), (args), NULL)
|
|
|
|
#define _PyCFunctionWithKeywords_TrampolineCall(meth, self, args, kw) \
|
|
_PyEM_TrampolineCall((meth), (self), (args), (kw))
|
|
|
|
#define descr_set_trampoline_call(set, obj, value, closure) \
|
|
((int)_PyEM_TrampolineCall((PyCFunctionWithKeywords)(set), (obj), (value), (PyObject*)(closure)))
|
|
|
|
#define descr_get_trampoline_call(get, obj, closure) \
|
|
_PyEM_TrampolineCall((PyCFunctionWithKeywords)(get), (obj), (PyObject*)(closure), NULL)
|
|
|
|
|
|
#else // defined(__EMSCRIPTEN__) && defined(PY_CALL_TRAMPOLINE)
|
|
|
|
#define _Py_EmscriptenTrampoline_Init(runtime)
|
|
|
|
#define _PyCFunction_TrampolineCall(meth, self, args) \
|
|
(meth)((self), (args))
|
|
|
|
#define _PyCFunctionWithKeywords_TrampolineCall(meth, self, args, kw) \
|
|
(meth)((self), (args), (kw))
|
|
|
|
#define descr_set_trampoline_call(set, obj, value, closure) \
|
|
(set)((obj), (value), (closure))
|
|
|
|
#define descr_get_trampoline_call(get, obj, closure) \
|
|
(get)((obj), (closure))
|
|
|
|
#endif // defined(__EMSCRIPTEN__) && defined(PY_CALL_TRAMPOLINE)
|
|
|
|
#endif // ndef Py_EMSCRIPTEN_SIGNAL_H
|