cpython/2024-10-13-15-04-58.gh-issue-125398.UW7Ndv.rst at 612ac283b81907d328891b102f5bfafcf62bd833 - cpython - Smart Yellow Git

mirrors/cpython

mirror of https://github.com/python/cpython.git synced 2024-11-27 23:47:29 +01:00

Julien 2a378dba98

gh-125398 : Convert paths in venv activate script when using Git Bash under Windows (GH-125399 )

* Convert paths in venv activate script when using Git Bash under Windows

With https://github.com/python/cpython/pull/112508 the check to converts paths when running on Windows was changed from using the non-posix environment variable `$OSTYPE` to using `uname` instead.

However this missed the fact that when running under Git Bash on Windows, uname reports `MINGW*` (`$OSTYPE` is still `msys`).

This results in `$PATH` being set to something like `D:\a\github-actions-shells\github-actions-shells\venv/Scripts:…`, instead of `/d/a/github-actions-shells/github-actions-shells/venv/Scripts`.

Notably, the Git Bash is the bash shell that’s used for GitHub Actions Windows runners, and ships with VSCode.

2024-10-19 18:34:41 +01:00

2 lines

130 B

ReStructuredText

Raw Blame History

Fix the conversion of the :envvar:`!VIRTUAL_ENV` path in the activate script in :mod:`venv` when running in Git Bash for Windows.