0
0
mirror of https://github.com/python/cpython.git synced 2024-11-24 17:47:13 +01:00

gh-101525: Skip test_gdb if the binary is relocated by BOLT. (gh-118572)

This commit is contained in:
Donghee Na 2024-09-02 22:24:53 +09:00 committed by GitHub
parent f1a0d96f41
commit f95fc4de11
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 19 additions and 0 deletions

View File

@ -343,6 +343,11 @@ def get_build_info():
if support.check_cflags_pgo(): if support.check_cflags_pgo():
# PGO (--enable-optimizations) # PGO (--enable-optimizations)
optimizations.append('PGO') optimizations.append('PGO')
if support.check_bolt_optimized():
# BOLT (--enable-bolt)
optimizations.append('BOLT')
if optimizations: if optimizations:
build.append('+'.join(optimizations)) build.append('+'.join(optimizations))

View File

@ -866,6 +866,15 @@ def check_cflags_pgo():
return any(option in cflags_nodist for option in pgo_options) return any(option in cflags_nodist for option in pgo_options)
def check_bolt_optimized():
# Always return false, if the platform is WASI,
# because BOLT optimization does not support WASM binary.
if is_wasi:
return False
config_args = sysconfig.get_config_var('CONFIG_ARGS') or ''
return '--enable-bolt' in config_args
Py_GIL_DISABLED = bool(sysconfig.get_config_var('Py_GIL_DISABLED')) Py_GIL_DISABLED = bool(sysconfig.get_config_var('Py_GIL_DISABLED'))
def requires_gil_enabled(msg="needs the GIL enabled"): def requires_gil_enabled(msg="needs the GIL enabled"):

View File

@ -24,6 +24,9 @@ if not sysconfig.is_python_build():
if support.check_cflags_pgo(): if support.check_cflags_pgo():
raise unittest.SkipTest("test_gdb is not reliable on PGO builds") raise unittest.SkipTest("test_gdb is not reliable on PGO builds")
if support.check_bolt_optimized():
raise unittest.SkipTest("test_gdb is not reliable on BOLT optimized builds")
def load_tests(*args): def load_tests(*args):
return support.load_package_tests(os.path.dirname(__file__), *args) return support.load_package_tests(os.path.dirname(__file__), *args)

View File

@ -0,0 +1,2 @@
Skip ``test_gdb`` if the binary is relocated by BOLT.
Patch by Donghee Na.