From ebcc578dff47b1dcffb634923bedc5361c8f29f6 Mon Sep 17 00:00:00 2001 From: Victor Stinner Date: Fri, 25 Oct 2024 11:14:52 +0200 Subject: [PATCH] gh-115754: Use Py_GetConstant(Py_CONSTANT_EMPTY_STR) (#125583) Replace PyUnicode_FromStringAndSize(NULL, 0) with Py_GetConstant(Py_CONSTANT_EMPTY_STR). --- Modules/_datetimemodule.c | 2 +- Modules/_io/textio.c | 2 +- Modules/getpath.c | 6 +++--- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/Modules/_datetimemodule.c b/Modules/_datetimemodule.c index e1bb98fcf05..b1102984cb5 100644 --- a/Modules/_datetimemodule.c +++ b/Modules/_datetimemodule.c @@ -1766,7 +1766,7 @@ make_Zreplacement(PyObject *object, PyObject *tzinfoarg) { PyObject *temp; PyObject *tzinfo = get_tzinfo_member(object); - PyObject *Zreplacement = PyUnicode_FromStringAndSize(NULL, 0); + PyObject *Zreplacement = Py_GetConstant(Py_CONSTANT_EMPTY_STR); if (Zreplacement == NULL) return NULL; diff --git a/Modules/_io/textio.c b/Modules/_io/textio.c index 68d16361962..0d851ee2115 100644 --- a/Modules/_io/textio.c +++ b/Modules/_io/textio.c @@ -1806,7 +1806,7 @@ textiowrapper_get_decoded_chars(textio *self, Py_ssize_t n) Py_ssize_t avail; if (self->decoded_chars == NULL) - return PyUnicode_FromStringAndSize(NULL, 0); + return Py_GetConstant(Py_CONSTANT_EMPTY_STR); /* decoded_chars is guaranteed to be "ready". */ avail = (PyUnicode_GET_LENGTH(self->decoded_chars) diff --git a/Modules/getpath.c b/Modules/getpath.c index d0128b20fae..18ddfaf8dbc 100644 --- a/Modules/getpath.c +++ b/Modules/getpath.c @@ -108,7 +108,7 @@ getpath_dirname(PyObject *Py_UNUSED(self), PyObject *args) Py_ssize_t end = PyUnicode_GET_LENGTH(path); Py_ssize_t pos = PyUnicode_FindChar(path, SEP, 0, end, -1); if (pos < 0) { - return PyUnicode_FromStringAndSize(NULL, 0); + return Py_GetConstant(Py_CONSTANT_EMPTY_STR); } return PyUnicode_Substring(path, 0, pos); } @@ -258,7 +258,7 @@ getpath_joinpath(PyObject *Py_UNUSED(self), PyObject *args) } Py_ssize_t n = PyTuple_GET_SIZE(args); if (n == 0) { - return PyUnicode_FromStringAndSize(NULL, 0); + return Py_GetConstant(Py_CONSTANT_EMPTY_STR); } /* Convert all parts to wchar and accumulate max final length */ wchar_t **parts = (wchar_t **)PyMem_Malloc(n * sizeof(wchar_t *)); @@ -302,7 +302,7 @@ getpath_joinpath(PyObject *Py_UNUSED(self), PyObject *args) PyErr_NoMemory(); return NULL; } - return PyUnicode_FromStringAndSize(NULL, 0); + return Py_GetConstant(Py_CONSTANT_EMPTY_STR); } final[0] = '\0';