From e61330b44f22b11a71f5bbcc17e309dd80e3e95f Mon Sep 17 00:00:00 2001 From: Irit Katriel <1055913+iritkatriel@users.noreply.github.com> Date: Wed, 4 May 2022 14:40:47 -0400 Subject: [PATCH] gh-92118: fix traceback of exceptions propagated from inside a contextlib.contextmanager (GH-92202) --- Lib/contextlib.py | 3 +++ Lib/test/test_contextlib.py | 27 +++++++++++++++++++ ...2-05-02-23-08-02.gh-issue-92118.9Mm9g4.rst | 1 + 3 files changed, 31 insertions(+) create mode 100644 Misc/NEWS.d/next/Library/2022-05-02-23-08-02.gh-issue-92118.9Mm9g4.rst diff --git a/Lib/contextlib.py b/Lib/contextlib.py index 4cff9c6a461..625bb33b12d 100644 --- a/Lib/contextlib.py +++ b/Lib/contextlib.py @@ -161,6 +161,7 @@ class _GeneratorContextManager( except RuntimeError as exc: # Don't re-raise the passed in exception. (issue27122) if exc is value: + exc.__traceback__ = traceback return False # Avoid suppressing if a StopIteration exception # was passed to throw() and later wrapped into a RuntimeError @@ -172,6 +173,7 @@ class _GeneratorContextManager( isinstance(value, StopIteration) and exc.__cause__ is value ): + exc.__traceback__ = traceback return False raise except BaseException as exc: @@ -183,6 +185,7 @@ class _GeneratorContextManager( # and the __exit__() protocol. if exc is not value: raise + exc.__traceback__ = traceback return False raise RuntimeError("generator didn't stop after throw()") diff --git a/Lib/test/test_contextlib.py b/Lib/test/test_contextlib.py index e238548be9e..bfe81173ddc 100644 --- a/Lib/test/test_contextlib.py +++ b/Lib/test/test_contextlib.py @@ -5,6 +5,7 @@ import os import sys import tempfile import threading +import traceback import unittest from contextlib import * # Tests __all__ from test import support @@ -87,6 +88,32 @@ class ContextManagerTestCase(unittest.TestCase): raise ZeroDivisionError() self.assertEqual(state, [1, 42, 999]) + def test_contextmanager_traceback(self): + @contextmanager + def f(): + yield + + try: + with f(): + 1/0 + except ZeroDivisionError as e: + frames = traceback.extract_tb(e.__traceback__) + + self.assertEqual(len(frames), 1) + self.assertEqual(frames[0].name, 'test_contextmanager_traceback') + self.assertEqual(frames[0].line, '1/0') + + # Repeat with RuntimeError (which goes through a different code path) + try: + with f(): + raise NotImplementedError(42) + except NotImplementedError as e: + frames = traceback.extract_tb(e.__traceback__) + + self.assertEqual(len(frames), 1) + self.assertEqual(frames[0].name, 'test_contextmanager_traceback') + self.assertEqual(frames[0].line, 'raise NotImplementedError(42)') + def test_contextmanager_no_reraise(self): @contextmanager def whee(): diff --git a/Misc/NEWS.d/next/Library/2022-05-02-23-08-02.gh-issue-92118.9Mm9g4.rst b/Misc/NEWS.d/next/Library/2022-05-02-23-08-02.gh-issue-92118.9Mm9g4.rst new file mode 100644 index 00000000000..b58ecdf40da --- /dev/null +++ b/Misc/NEWS.d/next/Library/2022-05-02-23-08-02.gh-issue-92118.9Mm9g4.rst @@ -0,0 +1 @@ +Fix a 3.11 regression in :func:`~contextlib.contextmanager`, which caused it to propagate exceptions with incorrect tracebacks.