From 56be5f5376d19ffe1a3859f19577dcb6df00332f Mon Sep 17 00:00:00 2001 From: Brett Cannon Date: Wed, 7 Sep 2016 14:07:16 -0700 Subject: [PATCH] Eliminate a tautological-pointer-compare warning found by Clang. --- Misc/NEWS | 2 ++ Modules/_scproxy.c | 14 +++++--------- 2 files changed, 7 insertions(+), 9 deletions(-) diff --git a/Misc/NEWS b/Misc/NEWS index 772cb7a93b7..56d8434d810 100644 --- a/Misc/NEWS +++ b/Misc/NEWS @@ -97,6 +97,8 @@ Library - Issue #16113: Add SHA-3 and SHAKE support to hashlib module. +- Eliminate a tautological-pointer-compare warning in _scproxy.c. + - Issue #27776: The :func:`os.urandom` function does now block on Linux 3.17 and newer until the system urandom entropy pool is initialized to increase the security. This change is part of the :pep:`524`. diff --git a/Modules/_scproxy.c b/Modules/_scproxy.c index 68be458bf4e..1ce4b776f3e 100644 --- a/Modules/_scproxy.c +++ b/Modules/_scproxy.c @@ -71,16 +71,12 @@ get_proxy_settings(PyObject* mod __attribute__((__unused__))) result = PyDict_New(); if (result == NULL) goto error; - if (&kSCPropNetProxiesExcludeSimpleHostnames != NULL) { - aNum = CFDictionaryGetValue(proxyDict, - kSCPropNetProxiesExcludeSimpleHostnames); - if (aNum == NULL) { - v = PyBool_FromLong(0); - } else { - v = PyBool_FromLong(cfnum_to_int32(aNum)); - } - } else { + aNum = CFDictionaryGetValue(proxyDict, + kSCPropNetProxiesExcludeSimpleHostnames); + if (aNum == NULL) { v = PyBool_FromLong(0); + } else { + v = PyBool_FromLong(cfnum_to_int32(aNum)); } if (v == NULL) goto error;