mirror of
https://github.com/python/cpython.git
synced 2024-11-21 12:59:38 +01:00
gh-126565: Skip zipfile.Path.exists
check in write mode (#126576)
When `zipfile.Path.open` is called, the implementation will check whether the path already exists in the ZIP file. However, this check is only required when the ZIP file is in read mode. By swapping arguments of the `and` operator, the short-circuiting will prevent the check from being run in write mode. This change will improve the performance of `open()`, because checking whether a file exists is slow in write mode, especially when the archive has many members.
This commit is contained in:
parent
450db61a78
commit
160758a574
@ -339,7 +339,7 @@ class Path:
|
||||
if self.is_dir():
|
||||
raise IsADirectoryError(self)
|
||||
zip_mode = mode[0]
|
||||
if not self.exists() and zip_mode == 'r':
|
||||
if zip_mode == 'r' and not self.exists():
|
||||
raise FileNotFoundError(self)
|
||||
stream = self.root.open(self.at, zip_mode, pwd=pwd)
|
||||
if 'b' in mode:
|
||||
|
@ -0,0 +1 @@
|
||||
Improve performances of :meth:`zipfile.Path.open` for non-reading modes.
|
Loading…
Reference in New Issue
Block a user